-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modernises the readme and makes it considerably prettier #6325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sort of wanted some better indication for the headers to be links since somereason github doesn't underline them. But doing <ins></ins>
on the link then would look funky with the subheading line. Past that was considering https://fontawesome.com/icons/arrow-up-right-from-square?f=classic&s=solid at the end of them, but then it'd seem like you should use that for all links, so I dunno its fine as is.
For me the first time looking at the page I was going to suggest you should add Guide to Git, because my attention was drawn more to the tip for the Guide to Contributing instead of the header's link. But I probably should just edit that article to better highlight guide to git on that page since all contributors need to follow those steps. It in a little git section doesn't make it seem relevant or important to contributing.
# About the pull request This PR is a follow up to #6325 fixing a couple broken links. # Changelog No player facing changes.
# About the pull request This PR is a follow up to cmss13-devs#6325 fixing a couple broken links. # Changelog No player facing changes.
infinite thanks to ParadiseSS13/Paradise#25259 for a lot of the nice formatting here
the icons here (aside from the logo) are made by me, using font awesome (free) icons
preview it here! https://github.com/harryob/cmss13/tree/new-readme